kiwitcms /
Kiwi
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 87 |
| Code Lines | 58 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | function pre_process_data(data) { |
||
| 10 | $(document).ready(function() { |
||
| 11 | var table = $("#resultsTable").DataTable({ |
||
| 12 | ajax: function(data, callback, settings) { |
||
|
|
|||
| 13 | var params = {}; |
||
| 14 | |||
| 15 | if ($('#id_name').val()) { |
||
| 16 | params['name__icontains'] = $('#id_name').val(); |
||
| 17 | } |
||
| 18 | |||
| 19 | if ($('#id_before').val()) { |
||
| 20 | params['create_date__lte'] = $('#id_before').data('DateTimePicker').date().format('YYYY-MM-DD 23:59:59'); |
||
| 21 | } |
||
| 22 | |||
| 23 | if ($('#id_after').val()) { |
||
| 24 | params['create_date__gte'] = $('#id_after').data('DateTimePicker').date().format('YYYY-MM-DD 00:00:00'); |
||
| 25 | } |
||
| 26 | |||
| 27 | if ($('#id_product').val()) { |
||
| 28 | params['product'] = $('#id_product').val(); |
||
| 29 | }; |
||
| 30 | |||
| 31 | if ($('#id_version').val()) { |
||
| 32 | params['product_version'] = $('#id_version').val(); |
||
| 33 | }; |
||
| 34 | |||
| 35 | if ($('#id_type').val()) { |
||
| 36 | params['type'] = $('#id_type').val(); |
||
| 37 | }; |
||
| 38 | |||
| 39 | if ($('#id_author').val()) { |
||
| 40 | params['author__username__startswith'] = $('#id_author').val(); |
||
| 41 | }; |
||
| 42 | |||
| 43 | if ($('#id_default_tester').val()) { |
||
| 44 | params['case__default_tester__username__startswith'] = $('#id_default_tester').val(); |
||
| 45 | }; |
||
| 46 | |||
| 47 | updateParamsToSearchTags('#id_tag', params); |
||
| 48 | |||
| 49 | params['is_active'] = $('#id_active').is(':checked'); |
||
| 50 | |||
| 51 | dataTableJsonRPC('TestPlan.filter', params, callback, pre_process_data); |
||
| 52 | }, |
||
| 53 | columns: [ |
||
| 54 | { data: "plan_id" }, |
||
| 55 | { |
||
| 56 | data: null, |
||
| 57 | render: function (data, type, full, meta) { |
||
| 58 | result = '<a href="/plan/'+ data.plan_id + '/">' + escapeHTML(data.name) + '</a>'; |
||
| 59 | if (! data.is_active) { |
||
| 60 | result = '<strike>' + result + '</strike>'; |
||
| 61 | } |
||
| 62 | return result; |
||
| 63 | } |
||
| 64 | }, |
||
| 65 | { data: "create_date" }, |
||
| 66 | { data: "product" }, |
||
| 67 | { data: "product_version" }, |
||
| 68 | { data: "type"}, |
||
| 69 | { data: "author" }, |
||
| 70 | { |
||
| 71 | data: "tag", |
||
| 72 | render: renderFromCache, |
||
| 73 | }, |
||
| 74 | ], |
||
| 75 | dom: "t", |
||
| 76 | language: { |
||
| 77 | loadingRecords: '<div class="spinner spinner-lg"></div>', |
||
| 78 | processing: '<div class="spinner spinner-lg"></div>', |
||
| 79 | zeroRecords: "No records found" |
||
| 80 | }, |
||
| 81 | order: [[ 0, 'asc' ]], |
||
| 82 | }); |
||
| 83 | |||
| 84 | hookIntoPagination('#resultsTable', table); |
||
| 85 | |||
| 86 | $('#btn_search').click(function() { |
||
| 87 | table.ajax.reload(); |
||
| 88 | return false; // so we don't actually send the form |
||
| 89 | }); |
||
| 90 | |||
| 91 | $('#id_product').change(update_version_select_from_product); |
||
| 92 | |||
| 93 | $('.bootstrap-switch').bootstrapSwitch(); |
||
| 94 | |||
| 95 | $('.selectpicker').selectpicker(); |
||
| 96 | }); |
||
| 97 |
Loading history...
This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function.